Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on unexpected commit message #67

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

MuriloDalRi
Copy link
Contributor

This will catch cases such as this PR which does not have an update-type in its commit message.

It should fix this error

Copy link
Contributor

@ChrisBAshton ChrisBAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this so quickly ⭐

lib/policy_manager.rb Outdated Show resolved Hide resolved
lib/policy_manager.rb Outdated Show resolved Hide resolved
@MuriloDalRi MuriloDalRi disabled auto-merge May 14, 2024 09:39
@MuriloDalRi MuriloDalRi force-pushed the MuriloDalRi-patch-1 branch 4 times, most recently from 5efb721 to 8ee19c5 Compare May 14, 2024 10:10
This will catch cases such as [this PR](https://github.com/alphagov/account-api/pull/874/commits) which does not have an `update-type` in its commit message.
Copy link
Contributor

@ChrisBAshton ChrisBAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🚀

@MuriloDalRi MuriloDalRi merged commit 52e3c58 into main May 14, 2024
9 checks passed
@MuriloDalRi MuriloDalRi deleted the MuriloDalRi-patch-1 branch May 14, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants