Update accordion guidance for v4.0.0 #1961
Conversation
|
✔️ You can preview this change here: 🔨 Explore the source changes: 76f2274 🔍 Inspect the deploy log: https://app.netlify.com/sites/govuk-design-system-preview/deploys/61bb0851b120a1000846ed17 😎 Browse the preview: https://deploy-preview-1961--govuk-design-system-preview.netlify.app |
calvin-lau-sig7
force-pushed
the
calvin-lau-sig7-accordion-guidance
branch
from
470011a to
2549f00
Compare
|
@calvin-lau-sig7 @hannalaakso and I were wondering whether the guidance should include any content about how the summary line should only contain 'phrasing content'. We're already adding info about phrasing content to the macros, but that's a pretty inconspicuous location for it... |
There was a problem hiding this comment.
This is looking great, thanks @calvin-lau-sig7 👏
Do we want to include something to address the issues raised by a user in #1684 (comment) about teams nesting accordions?
|
|
||
| Only add a summary line if it’s actually needed, as it's likely to make the button text too long. | ||
|
|
||
| If you’ve decided that you need the summary line, you must make it as short as possible. |
There was a problem hiding this comment.
Should we try to revise the content in the example below it to use shorter summary lines? Just realised that it doesn't actually follow the spirit of our guidance.
There was a problem hiding this comment.
Probably something to look at later after we publish, perhaps with the service manual team on their live pages?
We've haven't seen anything live that fits and I'd find it difficult to make a thought-out example.
I'll suggest it in an issue so we can do it as a next step.
There was a problem hiding this comment.
Added as issue to look at after release:
#1999
calvin-lau-sig7
requested review from
christopherthomasdesign and
vanitabarrett
christopherthomasdesign
dismissed
their stale review
Doing another review that supersedes this one
Co-authored-by: EoinShaughnessy <72507742+EoinShaughnessy@users.noreply.github.com>
Co-authored-by: EoinShaughnessy <72507742+EoinShaughnessy@users.noreply.github.com>
Co-authored-by: Vanita Barrett <vanita.barrett@digital.cabinet-office.gov.uk>
hannalaakso
force-pushed
the
calvin-lau-sig7-accordion-guidance
branch
from
06140d6 to
76f2274
Compare
This PR for the updated accordion guidance moves on from the working Google Doc.