Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump iframe-resizer from 4.3.7 to 4.3.9 #3296

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 13, 2023

Bumps iframe-resizer from 4.3.7 to 4.3.9.

Changelog

Sourced from iframe-resizer's changelog.

Version History

  • v4.3.9 Reduce package size

  • v4.3.7 Minor documentation updates and remove Bower package manager support

  • v4.3.6 Fix backwards compatablity of module.exports

  • v4.3.5 Fix path on module.exports

  • v4.3.4 #990 Fix readDataFromParent mouseEvents Boolean to strBool [Tony Living]

  • v4.3.3 #1100 Fix jQuery check [Gabriel Grant]

  • v4.3.2 #936 Allow max/min values for iFrame size to be set using units other than px [Luke Murray]

  • v4.3.1 #901 Fix backwards compatability issue with mouse events

  • v4.3.0 Add onMouseEnter and onMouseLeave event callbacks [DEPRECATED]

  • v4.2.11 Remove unicorn/prefer-number-properties from eslint rules and revert Number.parseInt to parseInt

  • v4.2.10 #787 Replace const with var in index.js for IE10 [Thomas Jaggi]

  • v4.2.9 #783 Bind requestAnimationFrame to window to fix issue with FireFox Content-Scripts [Greg Soltis]

  • v4.2.8 #779 Fix issue with javascript:void(0) and about:blank URLs [ceckoslab]

  • v4.2.7 Add support for NPM funding

  • v4.2.4 #772 Fix issue with iframes inside ShaddowDOM elements [Martin Belanger]

  • v4.2.3 #683 Include border top/bottom, plus padding top/bottom, when calculating heights on iframe with box-sizing: border-box; [Jim Doyle]. #768 Fix issue with hidden iframes [Tony Living]

  • v4.2.2 #761 Check for iframe.src when parsing it for remoteHost [Filip Stollar]

  • v4.2.1 #723 Fix option to turn off autoResize from iframe, when resizeFrom is set to parent [Dennis Kronbügel]

  • v4.2.0 Add onClose() event to parent

  • v4.1.1 #686 Fix IE11 regression with Object.values [Jonathan Lehman]

  • v4.1.0 #686 Split client(Height/Width) into document and window values [Bernhard Mäder]

  • v4.0.4 #674 Fix default export

  • v4.0.3 #606 Force height of clearFix div in iframe to 0

  • v4.0.2 #671 Fix issue with window resize

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Nov 13, 2023
@dependabot dependabot bot requested a review from a team November 13, 2023 10:54
@colinrotherham
Copy link
Contributor

@dependabot rebase

Bumps [iframe-resizer](https://github.com/davidjbradshaw/iframe-resizer) from 4.3.7 to 4.3.9.
- [Release notes](https://github.com/davidjbradshaw/iframe-resizer/releases)
- [Changelog](https://github.com/davidjbradshaw/iframe-resizer/blob/master/CHANGELOG.md)
- [Commits](davidjbradshaw/iframe-resizer@v4.3.7...v4.3.9)

---
updated-dependencies:
- dependency-name: iframe-resizer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/iframe-resizer-4.3.9 branch from df9a834 to bbdb770 Compare November 15, 2023 16:52
@colinrotherham
Copy link
Contributor

This is a breaking change since iframeResizer.contentWindow.min.js is no longer published

We should instead add this to #2977 where application-example.mjs can import, bundle and minify it

@colinrotherham
Copy link
Contributor

colinrotherham commented Nov 16, 2023

I've added a mention on davidjbradshaw/iframe-resizer#1195 (comment)

Rather than wait for #2977 to merge let's cherry pick the separate application-example.js Rollup bundle from ceef53a in release/5.0 so we can import iframeResizer.contentWindow.js into every example <iframe>

We'll just need to drop the type="module" attribute which can wait

Cherry picked from ceef53a but without the `type="module”` attribute
The npm package `iframe-resizer` has deleted the pre-minified `iframeResizer.contentWindow.min.js` file from their published files

See: davidjbradshaw/iframe-resizer#1195 (comment)
Copy link

netlify bot commented Nov 16, 2023

You can preview this change here:

Name Link
🔨 Latest commit 92eb212
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/65563f856b1f9700081982c1
😎 Deploy Preview https://deploy-preview-3296--govuk-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@colinrotherham
Copy link
Contributor

colinrotherham commented Nov 16, 2023

Ready for 2nd approval to import from the Rollup bundle application-example.js instead

Note: Commit 185f8cd is cherry picked from ceef53a which was already approved ✅

Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good for main. It seems a perfect candidate for splitting scripts that need to run in classic mode from those running as module for the release/5.0 branch, which would make us provide an example of what we mean by splitting some of the service or 3rd party code 😊

@colinrotherham colinrotherham merged commit 0f572fe into main Nov 17, 2023
12 checks passed
@colinrotherham colinrotherham deleted the dependabot/npm_and_yarn/iframe-resizer-4.3.9 branch November 17, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
Development

Successfully merging this pull request may close these issues.

2 participants