Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidance for tables with lots of data #3503

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

owenatgov
Copy link
Contributor

@owenatgov owenatgov commented Jan 31, 2024

What

Add a section to the bottom of the tables page with instructions on how and when to use the small text from tablet modifier introduced in alphagov/govuk-frontend#4630.

Closes alphagov/govuk-frontend#3922

Important

This change can only be merged after the new typography scale is launched as part of #3456

Why

So that we are advertising that this feature exists to users as well as adding some light guidance on minimising data in a table where possible.

Notes

I need to make it clear that this is currently only tied to 5.2 if you turn the feature flag on. This could link to the new scale guide that now lives in #3343.

Copy link

netlify bot commented Jan 31, 2024

You can preview this change here:

Name Link
🔨 Latest commit e1b540b
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/65c6413001b41e000867420d
😎 Deploy Preview https://deploy-preview-3503--govuk-design-system-preview.netlify.app/components/table
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@owenatgov owenatgov force-pushed the table-lots-of-data-class-guidance branch from 4aee93a to c8b9281 Compare January 31, 2024 16:20
@owenatgov owenatgov changed the base branch from main to typography-guidance February 8, 2024 16:11
@owenatgov owenatgov force-pushed the table-lots-of-data-class-guidance branch from 7a891c1 to 3cb03ed Compare February 8, 2024 16:48
@owenatgov
Copy link
Contributor Author

I'm pointing this at the typography-guidance branch because it means we can tackle the issue of illustrating that this is only for if you have the feature flag set to on holistically.

@owenatgov owenatgov marked this pull request as ready for review February 8, 2024 18:06
@owenatgov owenatgov force-pushed the table-lots-of-data-class-guidance branch from 3cb03ed to f52ec4e Compare February 8, 2024 18:10
@owenatgov owenatgov force-pushed the typography-guidance branch from 264b05c to ffac4ae Compare February 8, 2024 18:11
@owenatgov owenatgov force-pushed the table-lots-of-data-class-guidance branch 2 times, most recently from 43d8309 to 168d9b3 Compare February 8, 2024 18:16
@owenatgov owenatgov force-pushed the table-lots-of-data-class-guidance branch from 168d9b3 to e1b540b Compare February 9, 2024 15:13
@owenatgov owenatgov merged commit 4fc45b2 into typography-guidance Feb 9, 2024
13 checks passed
@owenatgov owenatgov deleted the table-lots-of-data-class-guidance branch February 9, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow table data font size to be customised on small screens for new typography scale
3 participants