-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guidance for tables with lots of data #3503
Merged
owenatgov
merged 1 commit into
typography-guidance
from
table-lots-of-data-class-guidance
Feb 9, 2024
Merged
Add guidance for tables with lots of data #3503
owenatgov
merged 1 commit into
typography-guidance
from
table-lots-of-data-class-guidance
Feb 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site configuration. |
owenatgov
force-pushed
the
table-lots-of-data-class-guidance
branch
from
January 31, 2024 16:20
4aee93a
to
c8b9281
Compare
owenatgov
force-pushed
the
table-lots-of-data-class-guidance
branch
from
February 2, 2024 12:23
c8b9281
to
7a891c1
Compare
querkmachine
reviewed
Feb 7, 2024
owenatgov
force-pushed
the
table-lots-of-data-class-guidance
branch
from
February 8, 2024 16:48
7a891c1
to
3cb03ed
Compare
I'm pointing this at the |
owenatgov
force-pushed
the
table-lots-of-data-class-guidance
branch
from
February 8, 2024 18:10
3cb03ed
to
f52ec4e
Compare
owenatgov
force-pushed
the
typography-guidance
branch
from
February 8, 2024 18:11
264b05c
to
ffac4ae
Compare
owenatgov
force-pushed
the
table-lots-of-data-class-guidance
branch
2 times, most recently
from
February 8, 2024 18:16
43d8309
to
168d9b3
Compare
owenatgov
force-pushed
the
table-lots-of-data-class-guidance
branch
from
February 9, 2024 15:13
168d9b3
to
e1b540b
Compare
claireashworth
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a section to the bottom of the tables page with instructions on how and when to use the small text from tablet modifier introduced in alphagov/govuk-frontend#4630.
Closes alphagov/govuk-frontend#3922
Important
This change can only be merged after the new typography scale is launched as part of #3456
Why
So that we are advertising that this feature exists to users as well as adding some light guidance on minimising data in a table where possible.
Notes
I need to make it clear that this is currently only tied to 5.2 if you turn the feature flag on. This could link to the new scale guide that now lives in #3343.