Homepage search test compatible with autocomplete #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of autocomplete for GOV.UK Site Search this test has started failing. The reason this is failing is that the auocomplete component makes use of an input with a role of "combobox" and thus locating an element with a role of "searchbox" fails. Rather than changing the role to "combobox" I have taken the approach of finding by label so that this can work with both input types. The reason for is that autcomplete is new and we have set-up a mechanism so it can be turned off quickly [1], should we do that it would be frustrating if the e2e tests started failing. [1]: alphagov/govuk-helm-charts#2832
theseanything
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of autocomplete for GOV.UK Site Search this test has started failing. The reason this is failing is that the auocomplete component makes use of an input with a role of "combobox" and thus locating an element with a role of "searchbox" fails.
Rather than changing the role to "combobox" I have taken the approach of finding by label so that this can work with both input types. The reason for is that autcomplete is new and we have set-up a mechanism so it can be turned off quickly 1, should we do that it would be frustrating if the e2e tests started failing.