Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "(opens in new tab)" suffix to links #18

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Conversation

aliuk2012
Copy link
Contributor

Links should have (opens in new tab) suffix so that users can expect the link to open in a new tab.

see https://design-system.service.gov.uk/styles/links/#external-links

Links should have `(opens in new tab)` suffix so that users can expect the link to open in a new tab.

see https://design-system.service.gov.uk/styles/links/#external-links
@aliuk2012 aliuk2012 marked this pull request as ready for review December 18, 2023 18:53
Copy link
Contributor

@DavidBiddle DavidBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall approach makes sense to me and code looks good. Raised a question about whether we need to bump the version number in the version file

@aliuk2012 aliuk2012 force-pushed the add-opens-in-new-tab branch from e428986 to 09d83e9 Compare December 19, 2023 09:30
@aliuk2012 aliuk2012 merged commit 70a6880 into main Dec 19, 2023
1 check passed
@aliuk2012 aliuk2012 deleted the add-opens-in-new-tab branch December 19, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants