Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max-width on the <select> element #1013

Merged
merged 2 commits into from
Oct 1, 2018
Merged

Conversation

kr8n3r
Copy link

@kr8n3r kr8n3r commented Sep 26, 2018

The <select> element's width is governed by the widths of its <option>'s.

When the text in the options grows large, the element can grow to > 100% of the width of its container and break the layout.

Fixes: #1009

The <select> element's width is governed by the widths of its <option>'s.

When the text in the options grows large, the element can grow to > 100% of the width of its container and break the layout
@kr8n3r kr8n3r added this to the [NEXT] milestone Sep 26, 2018
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-1013 September 26, 2018 15:27 Inactive
@kr8n3r kr8n3r changed the title Set max-width on select element Set max-width on the <select> element Sep 26, 2018
Copy link
Contributor

@timpaul timpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kr8n3r kr8n3r merged commit 5e8966c into master Oct 1, 2018
@kr8n3r kr8n3r deleted the set-max-width-on-select branch October 1, 2018 11:09
@kr8n3r kr8n3r mentioned this pull request Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants