Single field with error should have 'aria-describeby' attribute #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1054
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1054
NickColley
approved these changes
Nov 5, 2018
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1054
aliuk2012
force-pushed
the
single-field-error-describeby
branch
from
9cceaae
to
5926212
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1054
aliuk2012
force-pushed
the
single-field-error-describeby
branch
from
5926212
to
30a2fb3
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1054
|
changelog entry? |
aliuk2012
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
If you use a single checkbox without a
<fieldset>, and that single checkbox has an error message or hint, the error or hint will not associated with the field – they would normally be associated with thefieldset, but that isn't part of the output because it's a single checkbox in isolation.This PR adds the describeBy to the checkbox input if no fieldset exists
Example page: https://govuk-frontend-review-pr-1054.herokuapp.com/components/checkboxes/with-single-option-set-aria-describeby-on-input/preview
Trello ticket: https://trello.com/c/05zGTIPN/1453-associate-error-message-and-hint-with-checkbox-if-there-is-no-fieldset