Add tests for character-count script #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36degrees
approved these changes
Nov 7, 2018
|
|
||
| // Press 11 characters | ||
| await page.focus('.js-character-count') | ||
| for (let i = 0; i < 11; i++) { |
There was a problem hiding this comment.
Not blocking: would page.keyboard.type('A'.repeat(11)) have the same effect?
There was a problem hiding this comment.
Repeat doesn't seem to be working, unfortunately, so I'll have to leave the for.
| }) | ||
|
|
||
| describe('Character count', () => { | ||
| describe('when JavaScript is unavailable or fails', () => { |
There was a problem hiding this comment.
👌 Great to see tests for this.
|
@36degrees thanks. will update with your suggestions. |
|
@36degrees updated with suggestions except for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a basic set of tests for the character count component that were mistakenly missed from the initial PR by author's fault.
Issue: #1039