Allow describedBy parameter to be passed to the textarea component #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kr8n3r
changed the title
added 3 commits
January 31, 2019 13:51
If only describedBy attribute is provided and not error or hint messages exist, then out it only. Otherwise retain previous behaviour.
|
closing as it will need a redo based on other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix #1106 the textarea component needs to be able to accept the describedBy parameter.
This PR allows for that and the designed behaviour of that parameter is that if the hint text or error message or both exist, they take precedence over the custom describedBy parameter.
As describedBy is already listed in the table of available options there is no need to add it herebeing removed in #1181