Fix tabs bullet point character encoding issue when not enhanced #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will fix any issues with character encoding and is consistent with how we do this elsewhere (breadcrumbs)
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1247
|
I can't replicate the original issue - so I'm not sure I can confirm this fixes it. This renders fine for me though - but so does the original! |
|
Checked the deployed version out, and this is working fine now when swapping character encoding in Safari. Nice work 👍 |
NickColley
changed the title
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1247
36degrees
approved these changes
Mar 13, 2019
Make it easier to understand if you're looking at the source code or searching for the character. Co-Authored-By: nickcolley <nickcolley7@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix any issues with character encoding and is consistent with how we do this elsewhere (breadcrumbs)
I've not actually been able to replicate this, but it doesn't seem controversial to merge if the original contributor can confirm this fixes it.
Fixes #1246