Remove deprecated govuk-tag--inactive class
#2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2417
lfdebrux
force-pushed
the
ldeb-remove-govuk-tag--inactive
branch
from
6dfcb32 to
ddeee24
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2417
|
I've had a go at writing the changelog message, @EoinShaughnessy you might want to take a look as well? |
2 tasks
36degrees
reviewed
Nov 4, 2021
| @@ -60,6 +60,6 @@ examples: | |||
| data: | |||
| text: This is a new service – your feedback will help us to improve it | |||
| tag: | |||
| classes: govuk-tag--inactive | |||
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2417
lfdebrux
force-pushed
the
ldeb-remove-govuk-tag--inactive
branch
from
ed2d8e1 to
3149232
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2417
Class `govuk-tag--inactive` was replaced by `govuk-tag--grey` and deprecated in PR #1711. This commit replaces references to it in our tests, examples, and fixtures.
Class govuk-tag--inactive was replaced by govuk-tag--grey and deprecated in PR #1711. This commit removes the class completely. Users should replace any uses of this class with `.govuk-tag--grey`. Co-authored-by: Oliver Byford <oliver.byford@digital.cabinet-office.gov.uk>
lfdebrux
force-pushed
the
ldeb-remove-govuk-tag--inactive
branch
from
3149232 to
5d2fa1e
Compare
lfdebrux
changed the title
.govuk-tag--inactive classgovuk-tag--inactive class
lfdebrux
changed the title
govuk-tag--inactive classgovuk-tag--inactive class
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2417
36degrees
approved these changes
Nov 8, 2021
|
@lfdebrux Changelog update looks great! |
EoinShaughnessy
approved these changes
Nov 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1757 (also see here for details of how this is a breaking change for users).
Class
govuk-tag--inactivewas replaced bygovuk-tag--greyand deprecated in PR #1711.This commit removes the class completely. Users should replace any uses of this class with
.govuk-tag--grey.