Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the responsive type scale #2421

Merged
merged 8 commits into from
Feb 13, 2024
Merged

Adjust the responsive type scale #2421

merged 8 commits into from
Feb 13, 2024

Conversation

christopherthomasdesign
Copy link
Member

@christopherthomasdesign christopherthomasdesign commented Nov 4, 2021

What/Why

Make the following adjustments to the responsive type scale:

  • point 16 is now 16 across all screen sizes
  • point 19 is now 19 across all screen sizes
  • point 24 on small screens is now font size 21px instead of 18px and line height 25px instead of 20px
  • point 27 on small screens is now font size 21px instead of 18px and line height 25px instead of 20px
  • point 36 on small screens is now font size 27px instead of 24px and line height 30px instead of 25px

Additionally applies the following changes to components in response to the above type scale changes:

All of the above is behind the feature flag $govuk-new-typography-scale (#4701).

See the epic alphagov/govuk-design-system#2289 and the original investigation #2418 for further details about this change.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2421 November 4, 2021 16:00 Inactive
@christopherthomasdesign christopherthomasdesign linked an issue Jul 13, 2022 that may be closed by this pull request
4 tasks
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2421 September 15, 2022 17:15 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2421 September 15, 2022 17:22 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2421 November 24, 2022 10:14 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2421 November 28, 2022 18:49 Inactive
@owenatgov owenatgov mentioned this pull request May 3, 2023
@colinrotherham
Copy link
Contributor

colinrotherham commented May 4, 2023

I've rebased this PR with main to resolve srcpackages/govuk-frontend/src conflicts

@36degrees
Copy link
Contributor

@colinrotherham I don't think this rebase has worked as expected as the changes have been made to packages/govuk-frontend/dist.

Is there an easy fix?

@colinrotherham
Copy link
Contributor

@36degrees Yeah let me take a look now

We realised on the other PRs that git matched up dist for src because the files were identical. My fault for not coming back to this one. Give me a few mins, won't be long

@colinrotherham
Copy link
Contributor

✅ Done

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Spike adjustments to typography scale
6 participants