Remove bottom margin from navigation on tablets #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention seems to be to add the 10px margin only when the navigation is displayed inline (desktop), so switch to using a media query instead of using the responsive margin mixin. (Normally `govuk-responsive-margin(2, "bottom")` would create a 10px bottom margin on both mobile and tablet/desktop, except the margin on mobile is currently overridden by `margin: 0`)
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2447
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2447
vanitabarrett
approved these changes
Dec 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #2427.
The intention seems to be to add the 10px margin only when the navigation is displayed inline (desktop), so switch to using a media query instead of using the responsive margin mixin.
(Normally
govuk-responsive-margin(2, "bottom")would create a 10px bottom margin on both mobile and tablet/desktop, except the margin on mobile is currently overridden bymargin: 0)