Fix JavaScript errors when entering text into the Character Count in IE8 #2909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Character Count makes use of `Date.now` [1] to record the time of the last input to the textarea, debouncing screen reader updates to prevent them from being read too often or queued up. However, `Date.now` is not supported in IE8 [2]. This causes a script error on the `keyup` event when typing in to the Character Count, although the script continues to run. Add a polyfill for `Date.now` based on Polyfill.io's implementation [3], adapted to match the format used for the existing polyfills. [1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/now [2]: https://caniuse.com/mdn-javascript_builtins_date_now [3]: https://polyfill.io/v3/polyfill.js?version=3.111.0&features=Date.now&flags=always
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2909
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2909
colinrotherham
approved these changes
Oct 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Character Count makes use of
Date.nowto record the time of the last input to the textarea, debouncing screen reader updates to prevent them from being read too often or queued up.However,
Date.nowis not supported in IE8.This causes a script error on the
keyupevent when typing in to the Character Count, although the script continues to run.Add a polyfill for
Date.nowbased on Polyfill.io's implementation, adapted to match the format used for the existing polyfills.Closes #2904.