-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog entry for prototype kit config build #2981
Conversation
bd7a0b6
to
cd70ad6
Compare
CHANGELOG.md
Outdated
@@ -185,6 +185,8 @@ This was introduced in [pull request #2844: Remove compatibility mode from govuk | |||
|
|||
### Fixes | |||
|
|||
In [pull request 2851: Supporting v13 of the Prototype Kit](https://github.com/alphagov/govuk-frontend/pull/2851) we made `govuk-prototype-kit.config.json` part of our package build. The updated config adds JavaScript to initialise GOV.UK Frontend via the Prototype Kit plugin interface, including a new list of component macros and their import paths. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's that useful for users to know how this works in this much detail, and arguably this doesn't really tell them what govuk-prototype-kit.config.json
actually does.
I wonder if we should simplify to something like
In pull request 2851: Supporting v13 of the Prototype Kit we introduced support for the plugins system introduced in the upcoming Prototype Kit v13.
It's a bit repetitive given the PR title…. I wonder if we could just change the title of the PR to 'Support Prototype Kit v13' and then just list this with the rest of the fixes below?
@claireashworth do you have any thoughts on this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@36degrees Yeah that's sensible, I've pushed up your first suggestion
At least two other ### Fixes
sections included the format:
In [pull request XXXX: Description…]
So I pinched it 😊
If the fixes list is a better place, let me know
In terms of what it does, I knew this bit was further down. If it helps at all?
## 2.7.0 (Feature release)
🆕 New features:
- Added config file for prototype kit.
Added a configuration file for an experimental feature in Prototype kit to allow departments to use their own frontend alongside govuk-frontend
Thanks @matcarey (HMRC) for this contribution
([PR #1102](https://github.com/alphagov/govuk-frontend/pull/1102))
Cheers for the milestone tip 👍
Removed this from the milestone as the linked issue is already associated (so it's effectively represented in the milestone twice) |
cd70ad6
to
1a592af
Compare
CHANGELOG.md
Outdated
@@ -185,6 +185,8 @@ This was introduced in [pull request #2844: Remove compatibility mode from govuk | |||
|
|||
### Fixes | |||
|
|||
In [pull request 2851: Support Prototype Kit v13](https://github.com/alphagov/govuk-frontend/pull/2851) we introduced support for the plugins system introduced in the upcoming Prototype Kit v13. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In [pull request 2851: Support Prototype Kit v13](https://github.com/alphagov/govuk-frontend/pull/2851) we introduced support for the plugins system introduced in the upcoming Prototype Kit v13. | |
In [pull request 2851: Support Prototype Kit v13](https://github.com/alphagov/govuk-frontend/pull/2851) we introduced support for the plugins system included in the upcoming Prototype Kit v13. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice spot, double "introduced"! Pushed it up
@36degrees @claireashworth Good to go?
1a592af
to
dceaa7a
Compare
This PR adds a changelog entry for:
Closes #2889