Remove legacy and tabular fonts support #3574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
querkmachine
changed the title
8 tasks
| @@ -54,7 +54,7 @@ describe('@mixin govuk-typography-common', () => { | |||
| @include govuk-typography-common; | |||
| } | |||
| :root { | |||
| @include govuk-typography-common($font-family: $govuk-font-family-tabular); | |||
| @include govuk-typography-common($font-family: Helvetica); | |||
There was a problem hiding this comment.
Feels odd to have Helvetica here without a matching check for the output?
I appreciate we didn't before this edit, but we did (further down) in the tabular test
await expect(results).resolves.toMatchObject({
css: expect.stringContaining('font-family: Helvetica')
})
await expect(results).resolves.toMatchObject({
css: expect.stringContaining('font-family: "GDS Transport"')
})
colinrotherham
approved these changes
May 4, 2023
colinrotherham
force-pushed
the
remove-ie8-css
branch
from
78f4120 to
9862a1e
Compare
Additionally update tests that used $govuk-font-family-tabular as example data to use Helvetica instead.
colinrotherham
force-pushed
the
remove-compat-mode-legacy-fonts
branch
from
429e562 to
dc875b7
Compare
romaricpascal
pushed a commit
that referenced
this pull request
May 18, 2023
Remove legacy and tabular fonts support
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
$govuk-use-legacy-fontand$govuk-font-family-tabularsettings.Resolves #2791.
Changes
$govuk-use-legacy-fontbeing true.$govuk-font-family-tabularbeing true fromgovuk-fontmixin.$govuk-font-family-tabular.$govuk-use-legacy-font,$govuk-font-family-tabular,$govuk-font-family-ntaand$govuk-font-family-nta-tabularsettings.$govuk-font-familysetting to always use GDS Transport by default.$govuk-font-family-tabularas dummy data (usually as a shorthand for a non-GDS Transport font) to use Helvetica instead.