Enable new link styles by default #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In July 2021, we made some improvements to new link styles [1] which were released as part of v3.12.0. We introduced these changes behind a feature flag `$govuk-new-link-styles: true` which service teams needed to set before importing GOV.UK Frontend in order to opt-in. This was in case users: - needed to make changes to their service to introduce these new link styles consistently - wanted to avoid opting in if they have links within a multiple-column layout in your CSS, due to Known issue: hover state is mis-painted on links within CSS multiple-column layouts #2204 Now that #2204 has been fixed in Chromium, we can make the new link styles ‘opt-out’. [1]: #2350
36degrees
force-pushed
the
enable-new-link-styles-default
branch
from
5aff848 to
7647591
Compare
romaricpascal
approved these changes
May 10, 2023
Comment on lines
+13
to
+23
| #### New link styles are now enabled by default | ||
|
|
||
| In GOV.UK Frontend v3.12.0 we introduced new link styles which: | ||
|
|
||
| - have underlines that are consistently thinner and a bit further away from the link text | ||
| - have a clearer hover state, where the underline gets thicker to make the link stand out to users | ||
|
|
||
| The new link styles are now enabled by default. If you are setting `$govuk-new-link-styles` to `true` in your Sass you can now remove this. | ||
|
|
||
| This change was made in [pull request #3599: Enable new link styles by default](https://github.com/alphagov/govuk-frontend/pull/3599). | ||
|
|
There was a problem hiding this comment.
question Did we say this setting would be removed in the next breaking change? If that's the case, do we want to add a little note that the setting is deprecated?
There was a problem hiding this comment.
Actually, I'll merge this and if we do decide to deprecate it we can do that in a follow up PR too.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In July 2021, we made some improvements to new link styles which were released as part of v3.12.0.
We introduced these changes behind a feature flag
$govuk-new-link-styles: truewhich service teams needed to set before importing GOV.UK Frontend in order to opt-in.This was in case users:
Now that #2204 has been fixed in Chromium, we can make the new link styles ‘opt-out’.
Closes #2350