Simplify font family settings #3949
Conversation
36degrees
force-pushed
the
simplify-font-settings
branch
from
638a7b1 to
6b59673
Compare
36degrees
force-pushed
the
simplify-font-settings
branch
from
6b59673 to
e110288
Compare
Hmm, yeah, I think ideally we would have – it looks like the other font family 'settings' were deprecated at the point the new font was introduced back in 2019! Not sure it's worth doing an extra 4.x release just for this, but if we do another before v5 maybe we should include this deprecation then? Alternatively we hold off on this change until v6?
Yep, we also haven't mentioned the removal of the settings for the old version of the font which have already been removed. A quick search of Google suggests that people are most often using |
|
Thanks @36degrees I keep forgetting about GitHub code search too: Perhaps see if issues like #3918 will become another v4 release? Good to deprecate it before v5 |
Before we removed compatibility mode, the font-families file included multiple ‘settings’ (realistically, more like constants) that defined the font to be used depending on whether compatibility mode was enabled or not. Now that we only have one possible default font stack, we can remove the unnecessary abstraction. We also need to update the default value for the `$govuk-include-default-font-face` setting. Previously it checked whether the chosen font family was the default stack based on GDS Transport, but we can instead just check whether “GDS Transport” is in the font list. This also makes it more robust if somebody for example wants to update the setting to change the fallback fonts.
36degrees
force-pushed
the
simplify-font-settings
branch
from
e110288 to
de9bd97
Compare
|
Rebased and added a changelog entry |
|
If there is another 4.x release to deprecate things, please don’t forget #3877 |
Before we removed compatibility mode, the font-families file included multiple ‘settings’ (realistically, more like constants) that defined the font to be used depending on whether compatibility mode was enabled or not.
Now that we only have one possible default font stack, we can remove the unnecessary abstraction.
We also need to update the default value for the
$govuk-include-default-font-facesetting. Previously it checked whether the chosen font family was the default stack based on GDS Transport, but we can instead just check whether “GDS Transport” is in the font list. This also makes it more robust if somebody for example wants to update the setting to change the fallback fonts.