Allow border and hover colours to be overridden

[paulrobertlloyd]

$govuk-border-colour and $govuk-hover-colour are missing !default declarations, meaning its not possible to override these values in upstream projects as it is with other colour values in this file.

[owenatgov]

Great stuff, thanks @paulrobertlloyd! Could you please add a changelog entry? This would just be a fix so only needs to follow that format and be a list item under the unreleased fixes heading. I'm also happy to do this for you.

[paulrobertlloyd]

@owenatgov Done!

[owenatgov]

Lovely. Just needs a 2nd review.

[querkmachine]

LGTM! (Though it looks like a merge conflict snuck in literally as I was reviewing this.)

The name of the $govuk-hover-colour variable really doesn't helpfully describe what it actually does, huh? 😅

[paulrobertlloyd]

Merge conflict resolved.

[colinrotherham]

Cheers @paulrobertlloyd, do you mind rebasing or squashing away the merge commit that's snuck in?

[paulrobertlloyd]

Isn't there a big green button on GitHub that lets you do that? Unless it's disabled in this repo? (I've been making these changes via the GitHub website, safe faffing about with the repo on my machine again!)

[colinrotherham]

We have it turned off 😣

[paulrobertlloyd]

Bugger. Faff it is then.

[paulrobertlloyd]

Sorry, I’ve tried squashing commits in my patch-1 branch on my machine, but I’ve reached the limit of my Git skills (I briefly had this PR wanting to add over 500 commits). Somebody on your side will have to either do it, or tell me how. 😔

[36degrees]

I've rebased your branch against the latest main (which 'automatically' gets rid of the merge commit) and resolved a merge conflict with the changelog 👍🏻

[owenatgov]

With 2 approvals and a clean commit history (thanks @36degrees!) I'm going to merge this. Thanks again @paulrobertlloyd!

[paulrobertlloyd]

Thanks @36degrees!