Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move private workspace packages to devDependencies #4391

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

colinrotherham
Copy link
Contributor

Unlike npm, yarn is not happy unless optionalDependencies are published

Addresses user feedback from #4389 (comment)

Unlike npm, yarn is not happy unless `optionalDependencies` are published
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4391 October 27, 2023 09:35 Inactive
@colinrotherham colinrotherham added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) submitted by user labels Oct 27, 2023
@colinrotherham colinrotherham added this to the v5.0 milestone Oct 27, 2023
@github-actions
Copy link

📋 Stats

File sizes

File Size
dist/govuk-frontend-5.0.0-beta.0.min.css 114 KiB
dist/govuk-frontend-5.0.0-beta.0.min.js 37.85 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 76.77 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 72.08 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.8 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 113.99 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 37.83 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.3 KiB

Modules

File Size
all.mjs 68.4 KiB
components/accordion/accordion.mjs 21.05 KiB
components/button/button.mjs 4.18 KiB
components/character-count/character-count.mjs 20.49 KiB
components/checkboxes/checkboxes.mjs 5.31 KiB
components/error-summary/error-summary.mjs 5.49 KiB
components/exit-this-page/exit-this-page.mjs 15.49 KiB
components/header/header.mjs 3.39 KiB
components/notification-banner/notification-banner.mjs 4.02 KiB
components/radios/radios.mjs 4.31 KiB
components/skip-link/skip-link.mjs 3.3 KiB
components/tabs/tabs.mjs 9.07 KiB

View stats and visualisations on the review app


Action run for 92358f9

Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! ⛵

@colinrotherham colinrotherham merged commit ecf402f into main Oct 27, 2023
44 checks passed
@colinrotherham colinrotherham deleted the optional-dependencies branch October 27, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
Development

Successfully merging this pull request may close these issues.

3 participants