-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement transitional crown favicons (v5.0) #4445
Conversation
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for b71b377 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good @querkmachine 🙌
Mind if you and @claireashworth work together to add a new Breaking changes entry to the CHANGELOG specifically about:
- Removing old
govuk-apple-touch-*
icons - Removing old
govuk-mask-*
icons - Adding new
govuk-icon-*
icons - Adding new
manifest.json
file
Perhaps consolidating it with other removed images changes?
#### Remove the fallback GOV.UK crown logo from your HTML
As lots of services may have these files committed, probably want them to confirm the new files are reachable from assetPath
(or /assets
) without 404s
0658798
to
c45c3e5
Compare
I've added a changelog entry, though I have not consolidated it with the fallback crown entry as they feel conceptually separate and have fairly different associated HTML changes. |
Just a couple of minor suggestions from me. Also, should this be moved within the rest of the v5 information or is that done for the release rather than the pre-release? |
@claireashworth It's useful for beta participants for now (separately) until the beta's over, then combine? |
7454bb6
to
4225d0a
Compare
4225d0a
to
b71b377
Compare
Implements transitional crown assets for browser 'favourite' icons, homescreen icons and OpenGraph sharing graphics. That is, assets that utilise the formats agreed for Frontend v5 (#4175), but using the St. Edward's crown. Part of #4440.
This is intended to be a transitional step prior to launching the Tudor crown in a future version: #4354
Changes
sizes
attribute where Chrome would always use the ICO even when an SVG favicon was available (sizes
issue detailed here in section 2.3).rel="shortcut icon"
torel="icon"
. Theshortcut
keyword was only needed for supporting Internet Explorer 8 and earlier, which Frontend no longer does.apple-touch-icon
sizes smaller than 180×180. These aren't used by Apple devices released in the last few years and lower resolution Apple devices can scale down the larger image automatically.manifest.json
file listing all of the available icon sizes and their expected uses.Assets included
favicon.ico
favicon.svg
govuk-icon-180.png
govuk-icon-192.png
govuk-icon-512.png
govuk-icon-mask.svg
govuk-opengraph-image.png