Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Enable Terser ES module aware minification #4537

Closed
wants to merge 1 commit into from

Conversation

colinrotherham
Copy link
Contributor

@colinrotherham colinrotherham commented Dec 6, 2023

We forgot to enable Terser module: true now we use ES modules for govuk-frontend.min.js

Adding this config change to see what the diff looks like

Surprise: Nothing

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4537 December 6, 2023 17:08 Inactive
Copy link

github-actions bot commented Dec 6, 2023

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 113.72 KiB
dist/govuk-frontend-development.min.js 38.28 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 77.78 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 73.09 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.86 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 113.7 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 38.27 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.38 KiB

Modules

File Size
all.mjs 69.41 KiB
components/accordion/accordion.mjs 21.67 KiB
components/button/button.mjs 4.7 KiB
components/character-count/character-count.mjs 21.24 KiB
components/checkboxes/checkboxes.mjs 5.83 KiB
components/error-summary/error-summary.mjs 6.09 KiB
components/exit-this-page/exit-this-page.mjs 16.08 KiB
components/header/header.mjs 3.9 KiB
components/notification-banner/notification-banner.mjs 4.54 KiB
components/radios/radios.mjs 4.83 KiB
components/skip-link/skip-link.mjs 3.81 KiB
components/tabs/tabs.mjs 9.66 KiB

View stats and visualisations on the review app


Action run for ba8c215

Copy link

github-actions bot commented Dec 6, 2023

JavaScript changes to npm package

No changes found.

Action run for ba8c215

Copy link

github-actions bot commented Dec 6, 2023

Stylesheets changes to npm package

No changes found.

Action run for ba8c215

Copy link

github-actions bot commented Dec 6, 2023

Other changes to npm package

No changes found.

Action run for ba8c215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants