Merge pull request #2365 from alphagov/update-packages

Update packages
alphagov · Oct 26, 2023 · 62a3655 · 62a3655
2 parents bcc7c55 + 8443ead
commit 62a3655
Show file tree

Hide file tree

Showing 48 changed files with 3,690 additions and 2,098 deletions.
diff --git a/.github/workflows/test-heroku.yaml b/.github/workflows/test-heroku.yaml
@@ -18,11 +18,11 @@ jobs:
 
     steps:
     - uses: actions/checkout@v3
-    - name: Use Node v16
+    - name: Use Node v18
       uses: actions/setup-node@v3
       with:
         cache: 'npm'
-        node-version: '16'
+        node-version: '18'
     - name: Cache Cypress binary
       uses: actions/cache@v3
       with:

diff --git a/__tests__/utils/index.js b/__tests__/utils/index.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const os = require('os')
 const path = require('path')

diff --git a/bin/utils/index.js b/bin/utils/index.js
@@ -1,4 +1,3 @@
-
 // local dependencies
 const { spawn } = require('../../lib/exec')
 const fse = require('fs-extra')

diff --git a/cypress/e2e/dev/1-watch-files/watch-config.cypress.js b/cypress/e2e/dev/1-watch-files/watch-config.cypress.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const path = require('path')
 

diff --git a/cypress/e2e/dev/1-watch-files/watch-images.cypress.js b/cypress/e2e/dev/1-watch-files/watch-images.cypress.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const path = require('path')
 

diff --git a/cypress/e2e/dev/1-watch-files/watch-routes.cypress.js b/cypress/e2e/dev/1-watch-files/watch-routes.cypress.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const path = require('path')
 

diff --git a/cypress/e2e/dev/1-watch-files/watch-views.cypress.js b/cypress/e2e/dev/1-watch-files/watch-views.cypress.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const path = require('path')
 

diff --git a/cypress/e2e/dev/2-page-component-tests/checkboxes.cypress.js b/cypress/e2e/dev/2-page-component-tests/checkboxes.cypress.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const path = require('path')
 

diff --git a/cypress/e2e/dev/3-link-page-tests/branching-journey.cypress.js b/cypress/e2e/dev/3-link-page-tests/branching-journey.cypress.js
@@ -1,4 +1,3 @@
-
 // local dependencies
 const { waitForApplication, restoreStarterFiles } = require('../../utils')
 const { setUpPages, setUpBranchingPages } = require('./link-page-utils')

diff --git a/cypress/e2e/dev/3-link-page-tests/change-answers.cypress.js b/cypress/e2e/dev/3-link-page-tests/change-answers.cypress.js
@@ -1,4 +1,3 @@
-
 // local dependencies
 const { waitForApplication, restoreStarterFiles } = require('../../utils')
 const { setUpPages, setUpData } = require('./link-page-utils')

diff --git a/cypress/e2e/dev/3-link-page-tests/link-index-to-start.cypress.js b/cypress/e2e/dev/3-link-page-tests/link-index-to-start.cypress.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const path = require('path')
 

diff --git a/cypress/e2e/dev/3-link-page-tests/link-page-utils.js b/cypress/e2e/dev/3-link-page-tests/link-page-utils.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const path = require('path')
 

diff --git a/cypress/e2e/dev/3-link-page-tests/simple-journey.cypress.js b/cypress/e2e/dev/3-link-page-tests/simple-journey.cypress.js
@@ -1,4 +1,3 @@
-
 // local dependencies
 const { waitForApplication, restoreStarterFiles } = require('../../utils')
 const { setUpPages } = require('./link-page-utils')

diff --git a/cypress/e2e/dev/4-step-by-step-tests/step-by-step-journey.cypress.js b/cypress/e2e/dev/4-step-by-step-tests/step-by-step-journey.cypress.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const path = require('path')
 

diff --git a/cypress/e2e/dev/5-management-tests/change-service-name.cypress.js b/cypress/e2e/dev/5-management-tests/change-service-name.cypress.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const path = require('path')
 

diff --git a/cypress/e2e/dev/5-management-tests/clear-data-page.cypress.js b/cypress/e2e/dev/5-management-tests/clear-data-page.cypress.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const path = require('path')
 

diff --git a/cypress/e2e/dev/5-management-tests/edit-home-page.cypress.js b/cypress/e2e/dev/5-management-tests/edit-home-page.cypress.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const path = require('path')
 

diff --git a/cypress/e2e/dev/5-management-tests/management-available.cypress.js b/cypress/e2e/dev/5-management-tests/management-available.cypress.js
@@ -1,4 +1,3 @@
-
 // local dependencies
 const { waitForApplication } = require('../../utils')
 

diff --git a/cypress/e2e/dev/5-management-tests/no-autodatastore-on-management-pages.cypress.js b/cypress/e2e/dev/5-management-tests/no-autodatastore-on-management-pages.cypress.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const path = require('path')
 

diff --git a/cypress/e2e/dev/6-layout-tests/default-layout.cypress.js b/cypress/e2e/dev/6-layout-tests/default-layout.cypress.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const path = require('path')
 

diff --git a/cypress/e2e/plugins/0-mock-plugin-tests/install-plugin-via-cli-test.cypress.js b/cypress/e2e/plugins/0-mock-plugin-tests/install-plugin-via-cli-test.cypress.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const path = require('path')
 

diff --git a/cypress/e2e/plugins/0-mock-plugin-tests/multi-combined-plugin-test.cypress.js b/cypress/e2e/plugins/0-mock-plugin-tests/multi-combined-plugin-test.cypress.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const path = require('path')
 

diff --git a/cypress/e2e/prod/1-home-page-tests/home-page-in-production.cypress.js b/cypress/e2e/prod/1-home-page-tests/home-page-in-production.cypress.js
@@ -1,4 +1,3 @@
-
 // local dependencies
 const { authenticate, restoreStarterFiles } = require('../../utils')
 

diff --git a/cypress/e2e/prod/2-management-tests/management-not-available.cypress.js b/cypress/e2e/prod/2-management-tests/management-not-available.cypress.js
@@ -1,4 +1,3 @@
-
 // local dependencies
 const { authenticate, restoreStarterFiles } = require('../../utils')
 

diff --git a/cypress/e2e/step-by-step-utils.js b/cypress/e2e/step-by-step-utils.js
@@ -1,4 +1,3 @@
-
 const showHideAllLinkQuery = '.app-step-nav__controls button'
 const toggleButtonQuery = (step) => `[data-position="${step}"]`
 const showHideLinkQuery = (step) => `[data-position="${step}"]`

diff --git a/cypress/e2e/styles/1-watch-styles/watch-custom-styles.cypress.js b/cypress/e2e/styles/1-watch-styles/watch-custom-styles.cypress.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const path = require('path')
 

diff --git a/cypress/e2e/styles/1-watch-styles/watch-styles.cypress.js b/cypress/e2e/styles/1-watch-styles/watch-styles.cypress.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const path = require('path')
 

diff --git a/cypress/fixtures/plugins/plugin-bar/filters.js b/cypress/fixtures/plugins/plugin-bar/filters.js
@@ -1,4 +1,3 @@
-
 // local dependencies
 const { addFilter } = require('govuk-prototype-kit').views
 

diff --git a/cypress/fixtures/plugins/plugin-bar/scripts/bar.js b/cypress/fixtures/plugins/plugin-bar/scripts/bar.js
@@ -1,4 +1,3 @@
-
 window.BAR = window.BAR || {}
 window.BAR.Modules = window.BAR.Modules || {};
 

diff --git a/cypress/fixtures/plugins/plugin-baz/filters.js b/cypress/fixtures/plugins/plugin-baz/filters.js
@@ -1,4 +1,3 @@
-
 // local dependencies
 const { addFilter } = require('govuk-prototype-kit').views
 

diff --git a/cypress/fixtures/plugins/plugin-baz/scripts/baz.js b/cypress/fixtures/plugins/plugin-baz/scripts/baz.js
@@ -1,4 +1,3 @@
-
 window.BAZ = window.BAZ || {}
 window.BAZ.Modules = window.BAZ.Modules || {};
 

diff --git a/cypress/fixtures/plugins/plugin-foo/scripts/foo.js b/cypress/fixtures/plugins/plugin-foo/scripts/foo.js
@@ -1,4 +1,3 @@
-
 window.FOO = window.FOO || {}
 window.FOO.Modules = window.FOO.Modules || {};
 

diff --git a/cypress/scripts/run-starter-prototype.js b/cypress/scripts/run-starter-prototype.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const os = require('os')
 const path = require('path')

diff --git a/index.js b/index.js
@@ -1,4 +1,3 @@
-
 // local dependencies
 const filtersApi = require('./lib/filters/api').external
 const functionsApi = require('./lib/functions/api').external

diff --git a/lib/build.js b/lib/build.js
@@ -1,4 +1,3 @@
-
 // node dependencies
 const path = require('path')
 

diff --git a/lib/exec.js b/lib/exec.js
@@ -1,4 +1,3 @@
-
 // npm dependencies
 const { spawn: crossSpawn } = require('cross-spawn')
 

diff --git a/lib/filters/api.js b/lib/filters/api.js
@@ -1,4 +1,3 @@
-
 let environment
 const whenEnvIsAvailable = []
 

diff --git a/lib/filters/core-filters.js b/lib/filters/core-filters.js
@@ -1,4 +1,3 @@
-
 // local dependencies
 const { addFilter, getFilter } = require('../../').views
 

diff --git a/lib/routes/api.js b/lib/routes/api.js
@@ -1,4 +1,3 @@
-
 // npm dependencies
 const express = require('express')
 

diff --git a/lib/usage-data.js b/lib/usage-data.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const fs = require('fs')
 const os = require('os')

diff --git a/lib/utils/index.js b/lib/utils/index.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const crypto = require('crypto')
 const fs = require('fs')

diff --git a/listen-on-port.js b/listen-on-port.js
@@ -1,4 +1,3 @@
-
 // npm dependencies
 const { runErrorServer } = require('./lib/errorServer')
 const { verboseLog } = require('./lib/utils/verboseLogger')

diff --git a/migrator/logger.js b/migrator/logger.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const fsp = require('fs').promises
 const os = require('os')

diff --git a/migrator/migration-steps.js b/migrator/migration-steps.js
@@ -1,4 +1,3 @@
-
 // core dependencies
 const path = require('path')
 
@@ -228,7 +227,7 @@ async function updateLayoutIfUnchanged (filePath, starterFilePath) {
 }
 
 async function updateIfUnchanged (filePaths, additionalStep) {
-  const results = await Promise.all(filePaths.map(async filePath => {
+  return Promise.all(filePaths.map(async filePath => {
     const matchFound = await matchAgainstOldVersions(filePath)
 
     const reporter = await addReporter(`Overwrite ${filePath}`)
@@ -251,7 +250,6 @@ async function updateIfUnchanged (filePaths, additionalStep) {
     await reporter(result)
     return result
   }))
-  return results
 }
 
 async function updateUnbrandedLayouts (dir) {

diff --git a/migrator/reporter.js b/migrator/reporter.js
@@ -1,4 +1,3 @@
-
 // npm dependencies
 const c = require('ansi-colors')