Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix global styles for unbranded layout
I noticed that one of the text lines wasn't formatted correctly on the password page, because it was missing the `govuk-body` class. Digging deeper, it seems that we used to expect that the GOV.UK frontend global styles would work for pages using the 'unbranded' stylesheet, but it stopped in the rework for v13. The issue is that we import the govuk-frontend settings in the unbranded template, before we set the govuk-global-styles variable to true. Previously this was fine because we were setting that variable strongly, however in v13 we added the `!default` thingy [[1]], because we want users to be able to override the value in `settings.scss`. I think this behaviour is unavoidable, but luckily there is a workaround; we were only importing the settings to get `govuk-body-background-colour`, so we can import just the settings we need rather than the whole thing. It's a bit hacky, but it should hopefully work for now.
- Loading branch information