Fixing govuk frontend until they release update #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A bit confused about the empty file |
BenSurgisonGDS
approved these changes
Oct 3, 2022
lfdebrux
reviewed
Oct 3, 2022
nataliecarey
force-pushed
the
fixing-govuk-frontend-until-they-release-update
branch
from
7ecf3f7
to
a686db3
Compare
lfdebrux
reviewed
Oct 3, 2022
lfdebrux
suggested changes
Oct 5, 2022
…ontend release a v13 version of the config.
BenSurgisonGDS
force-pushed
the
fixing-govuk-frontend-until-they-release-update
branch
from
a9fcb9b
to
36d24e9
Compare
nataliecarey
force-pushed
the
fixing-govuk-frontend-until-they-release-update
branch
from
36d24e9
to
da83e5a
Compare
|
We should mention in the changelog that users will need to import component macros themselves for older versions of GOV.UK Frontend. |
lfdebrux
approved these changes
Oct 10, 2022
nataliecarey
deleted the
fixing-govuk-frontend-until-they-release-update
branch
lfdebrux
added a commit
that referenced
this pull request
Oct 28, 2022
I noticed that one of the text lines wasn't formatted correctly on the password page, because it was missing the `govuk-body` class. Digging deeper, it seems that we used to expect that the GOV.UK frontend global styles would work for pages using the 'unbranded' stylesheet, but it stopped in the rework for v13. The issue is that we import the govuk-frontend settings in the unbranded template, before we set the govuk-global-styles variable to true. Previously this was fine because we were setting that variable strongly, however in v13 we added the `!default` thingy [[1]], because we want users to be able to override the value in `settings.scss`. I think this behaviour is unavoidable, but luckily there is a workaround; we were only importing the settings to get `govuk-body-background-colour`, but the value of that is just `#fffff` (white). We can set the value to white without needing to import any settings. If the GOV.UK Design System decides to go with an off-white body background colour in the future, that's also fine, the point of the unbranded template is not to look like GOV.UK, so we're not losing anything by hardcoding the value. [1]: #1640 (comment)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we're being held up by the PR to get the new config file into govuk-frontend. We can't really release because core features are broken and need working around.
This PR puts in the workarounds for the user, it detects the absence of
nunjucksMacrosand puts in the fixes needed for older versions of govuk-frontend (including the current live version).There are two reasons to include this work: