Support deprecated check-your-answers table styles #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure we support existing prototypes using the old check your answers pattern - where using a table was recommended, add the styles back in - but mark these as deprecated. As the new styles are namespaced using .govuk- these are opt-in, so we can release without making a breaking change. In future, we can remove .check-your-answers, the next time we make a breaking change to the prototype kit.
36degrees
approved these changes
Jul 13, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure we support existing prototypes using the old check your
answers pattern - where using a table was recommended, add the styles
back in - but mark these as deprecated.
These were removed in #365.
As the new check-your-answers styles are namespaced using
.govuk-these are opt-in, so wecan release without making a breaking change.
In future, we can remove
.check-your-answers, the next time we make abreaking change to the prototype kit.