Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a validation example for page-per-thing #543

Closed
edwardhorsford opened this issue Aug 8, 2017 · 0 comments · Fixed by #552
Closed

Add a validation example for page-per-thing #543

edwardhorsford opened this issue Aug 8, 2017 · 0 comments · Fixed by #552

Comments

@edwardhorsford
Copy link
Contributor

The current validation examples don't cover page-per-thing single question pages - which are likely the most common page template.

Current examples:

  • Single question with lots of content (valid, but less likely)
  • Multiple question

We're missing a simple single question - could potentially do one for text inputs and one for checkboxes or radios.

Raised in favour of #541
@edwardhorsford edwardhorsford mentioned this issue Aug 8, 2017
Closed
paulwaitehomeoffice pushed a commit to paulwaitehomeoffice/govuk_elements that referenced this issue Sep 13, 2017
@pauldwaite
Added examples for simple single question form pages, with and withou…
89d09a0 
…t errors. See alphagov#543.
paulwaitehomeoffice pushed a commit to paulwaitehomeoffice/govuk_elements that referenced this issue Sep 13, 2017
@pauldwaite
Added examples for simple single question form pages, with and withou…
e346231 
…t errors. See alphagov#543.
@paulwaitehomeoffice paulwaitehomeoffice mentioned this issue Sep 14, 2017
Merged
paulwaitehomeoffice pushed a commit to paulwaitehomeoffice/govuk_elements that referenced this issue Sep 21, 2017
@pauldwaite
Added examples for simple single question form pages, with and withou…
05b01cd 
…t errors. See alphagov#543.
paulwaitehomeoffice pushed a commit to paulwaitehomeoffice/govuk_elements that referenced this issue Sep 21, 2017
@pauldwaite
Added examples for simple single question form pages, with and withou…
d5a18ba 
…t errors. See alphagov#543.
paulwaitehomeoffice pushed a commit to paulwaitehomeoffice/govuk_elements that referenced this issue Oct 3, 2017
@pauldwaite
Added examples for simple single question form pages, with and withou…
9c1f73e 
…t errors. See alphagov#543.
paulwaitehomeoffice pushed a commit to paulwaitehomeoffice/govuk_elements that referenced this issue Oct 10, 2017
@pauldwaite
Added examples for simple single question form pages, with and withou…
48e6101 
…t errors. See alphagov#543.
paulwaitehomeoffice pushed a commit to paulwaitehomeoffice/govuk_elements that referenced this issue Oct 10, 2017
@pauldwaite
Added examples for simple single question form pages, with and withou…
3faf433 
…t errors. See alphagov#543.
paulwaitehomeoffice pushed a commit to paulwaitehomeoffice/govuk_elements that referenced this issue Oct 16, 2017
@pauldwaite
Added examples for simple single question form pages, with and withou…
4da9b56 
…t errors. See alphagov#543.
paulwaitehomeoffice pushed a commit to paulwaitehomeoffice/govuk_elements that referenced this issue Oct 30, 2017
@pauldwaite
Added examples for simple single question form pages, with and withou…
e7040c0 
…t errors. See alphagov#543.
paulwaitehomeoffice pushed a commit to paulwaitehomeoffice/govuk_elements that referenced this issue Nov 6, 2017
@pauldwaite
Add single-question form page examples, and make heading classes disp…
6e39ce0 
…lay:block

The existing single-question form page examples did not include any where the page’s h1 contained the label or legend for the form field/s, and did not include error styling.
To allow form hints and error messages to stay within the label tag without picking up heading styles, we needed to apply the heading class to a span inside the label, and thus add display:block to the heading classes so that it works consistently.
See alphagov#543
paulwaitehomeoffice pushed a commit to paulwaitehomeoffice/govuk_elements that referenced this issue Nov 6, 2017
@pauldwaite
Add single-question form page examples, and make heading classes disp…
8f88ccc 
…lay:block

The existing single-question form page examples did not include any where the page’s h1 contained the label or legend for the form field/s, and did not include error styling.
To allow form hints and error messages to stay within the label tag without picking up heading styles, we needed to apply the heading class to a span inside the label, and thus add display:block to the heading classes so that it works consistently.
See alphagov#543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@edwardhorsford