Fixed radio button jumping problem on Safari #323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Unfortunately while this potentially fixes the problem in Safari and Chrome, they’re the two browsers on macOS that don’t resize the inputs visually based on their applied size. Either way, we’re looking to replace this style with a new one for radios and checkboxes, which is currently going through testing. That will replace all of this code, so it’s probably not worth your time coming up with a new version of this patch that works for everyone at this point. If you’d like to test out the new code I’d love your opinions. |
gavboulton
pushed a commit
to gavboulton/govuk_elements
that referenced
this pull request
Oct 20, 2016
# 4.18.1 - Fix error in IE - remove trailing comma from shimLinksWithButtonRole JavaScript ([PR alphagov#323](alphagov/govuk_frontend_toolkit#323)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated block-label input styles
What problem does the pull request solve?
To fix radio button jumping bug on Safari browser
What does it do?
It fixes the position
How has this been tested?
Manually on Safari, Chrome
Executed grunt test-default task
Screenshots (if appropriate):
Hard to catch the screenshot as it is on press down
What type of change is it?
Put an
xin all the boxes that apply