Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect form validation error in title #509

Merged
merged 3 commits into from
Jul 31, 2017
Merged

Reflect form validation error in title #509

merged 3 commits into from
Jul 31, 2017

Commits on Jul 28, 2017

  1. Move duplicate validation implementation advice into its own partial

    @selfthinker
    selfthinker committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    6d4dd5e View commit details
    Browse the repository at this point in the history

  2. Rearrange validation implementation advice 

    Some points of the validation implementation advice were duplicated.
This is rearranging and rephrasing them to merge them together.
    @selfthinker
    selfthinker committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    e0455df View commit details
    Browse the repository at this point in the history

  3. Reflect form validation error in title 

    This adds guidance to prefix the `title` with "Error: "
to alert screen reader users as soon as possible
that there has been an error after submitting a form.
It also adds the required code to the two validation example forms.

This was very successfully user-tested with screen reader users,
with users actively pointing out how useful it is.
    @selfthinker
    selfthinker committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    009d405 View commit details
    Browse the repository at this point in the history