Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make old JAWS recognise disabled buttons #532

Merged
merged 1 commit into from
Jul 24, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/views/guide_buttons.html
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,13 @@ <h3 class="heading-medium" id="button-disabled">Disabled buttons</h3>
<ul class="list list-bullet text">
<li>don’t disable buttons, unless there’s a good reason to</li>
<li>if you have to disable buttons, make sure they look like you can’t click them (use 50% opacity)</li>
<li>use the <code class="code">aria-disabled</code> attribute for older screen readers</li>
<li>an example of a useful disabled option is a calendar with greyed out days where no bookings are available</li>
<li>provide another way for the user to continue, add an error message or text to explain why the button is disabled</li>
</ul>

<div class="example">
<button class="button" disabled="disabled">Disabled primary button</button>
<button class="button" disabled="disabled" aria-disabled="true">Disabled primary button</button>
</div>

<pre>
Expand Down
2 changes: 1 addition & 1 deletion app/views/snippets/buttons_button_disabled.html
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<input class="button" type="submit" value="Save and continue" disabled="disabled">
<input class="button" type="submit" value="Save and continue" disabled="disabled" aria-disabled="true">