Remove Heroku deploy from Travis jobs, update docs #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heroku is now configured to deploy the latest-release branch to the govuk-elements-sass-release app when CI passes, which means Travis no longer needs to do this.
- Update the automatic deploy comment to make it clearer - Remove `on: master` from the create-release job as this is the default for deploy providers and it’s confusing to have it on one and not the others - Rename the ’create release’ stage to better reflect what it actually does (‘check for new release’) - Re-word confusing comments to make it clearer how and when the deploy stage gets triggered - Reduce the line lengths of the file by moving comments above sections
govuk-design-system-ci
temporarily deployed
to
govuk-elements-review-pr-566
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does the pull request solve?
Heroku is now configured to deploy the latest-release branch to the govuk-elements-sass-release app when CI passes, which means Travis no longer needs to do this.
The documentation around the Travis config is not terribly clear.
How has this been tested?
It hasn't, because Travis can't be set up locally to test with.
What type of change is it?
Has the documentation been updated?