-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GOVUK.ShowHideContent JavaScript #315
Commits on Aug 22, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 1c0db7f - Browse repository at this point
Copy the full SHA 1c0db7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 51de396 - Browse repository at this point
Copy the full SHA 51de396View commit details -
Slight performance tweak to GOVUK.ShowHideContent
Avoid DOM parentNode traversal (after init, `aria-controls` attribute can be used instead).
Configuration menu - View commit details
-
Copy full SHA for ba6936e - Browse repository at this point
Copy the full SHA ba6936eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 77268de - Browse repository at this point
Copy the full SHA 77268deView commit details -
Configuration menu - View commit details
-
Copy full SHA for cbbcb38 - Browse repository at this point
Copy the full SHA cbbcb38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63362d8 - Browse repository at this point
Copy the full SHA 63362d8View commit details
Commits on Aug 23, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 6caa441 - Browse repository at this point
Copy the full SHA 6caa441View commit details -
Run handleRadioContent only on controlling radios
This reduces the radios we are trying to hide the content for to only be those which are controls. This covers the following use cases: 1. If the control sent in is not a control All content controlled by radios in this group will be hidden. 2. If the control sent in is a control All content controlled by radios in this group will be hidden and the content for the control will be shown.
Configuration menu - View commit details
-
Copy full SHA for 3999832 - Browse repository at this point
Copy the full SHA 3999832View commit details -
Add fixes for standard JS errors
The following errors came up: - 80:54: Block must not be padded by blank lines. - 105:12: Closing curly brace does not appear on the same line as the subsequent block.
Configuration menu - View commit details
-
Copy full SHA for 9d9b3c6 - Browse repository at this point
Copy the full SHA 9d9b3c6View commit details
Commits on Aug 24, 2016
-
Re-point paths to jasmine runner files
They were rewritten to point at a local version of jasmine-core but this is not listed in our package.json so only exists in /node_modules as a dependency of grunt-contrib-jasmine.
Configuration menu - View commit details
-
Copy full SHA for 91a8ed7 - Browse repository at this point
Copy the full SHA 91a8ed7View commit details -
Only bind events to controlling selection buttons
At the moment the ShowHideContent module binds events to all radios and checkboxes in block-labels. This mean a user clicking on any block-label in the page will trigger code to show/hide its related content, even if there is none. This commit limits the block-labels that trigger the code to show/hide content related to it to those that have that relationship.
Configuration menu - View commit details
-
Copy full SHA for 420b23d - Browse repository at this point
Copy the full SHA 420b23dView commit details -
Remove parenthesis from return expression
The `result` variable will always be a string (rather than an expression) so doesn't need parenthesis.
Configuration menu - View commit details
-
Copy full SHA for a8ae9ee - Browse repository at this point
Copy the full SHA a8ae9eeView commit details