Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix role click shim #347

Merged
merged 3 commits into from
Nov 22, 2016
Merged

Fix role click shim #347

merged 3 commits into from
Nov 22, 2016

Commits on Oct 28, 2016

  1. Update the shim link handler to use keydown instead of keyup 

    With keyup we can't prevent scroll of the page when pressing space
so if we use keydown instead this will allow us to stop the scroll
with the expected behaviour
    @NickColley
    NickColley committed Oct 28, 2016
    Configuration menu
    Copy the full SHA
    c332e04 View commit details
    Browse the repository at this point in the history

  2. Simplify shim links shim 

    Before we had options to customize the shim when there doesn't
seem to be the need

This commit simplifies the shim to enable the space to click behaviour on all elements
with role="button"
    @NickColley
    NickColley committed Oct 28, 2016
    Configuration menu
    Copy the full SHA
    196c7d4 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2016

  1. Add link for context of why we're shimming this

    @NickColley
    NickColley committed Nov 7, 2016
    Configuration menu
    Copy the full SHA
    472fabc View commit details
    Browse the repository at this point in the history