Skip to content

Commit

Permalink
Ignore RequiredRubyVersion rubocop warning
Browse files Browse the repository at this point in the history
Bumping required Ruby version to 3.1.x as there are no apps that I've
found using lower versions, however a number of apps are still on 3.1.x
so silencing the warning until we specify the required version to be
3.2.x. 3.1.x is still compatible with 3.2.x from the testing matrix and
testing a couple apps manually.
  • Loading branch information
1pretz1 committed Oct 2, 2023
1 parent 5e77179 commit 39bbb60
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# Due to https://github.com/actions/runner/issues/849, we have to use quotes for '3.0'
ruby: ['3.0', 3.1, 3.2]
ruby: [3.1, 3.2]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion govuk_publishing_components.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Gem::Specification.new do |s|
s.description = "A gem to document components in GOV.UK frontend applications"
s.homepage = "https://github.com/alphagov/govuk_publishing_components"
s.license = "MIT"
s.required_ruby_version = ">= 3.0"
s.required_ruby_version = ">= 3.1" # rubocop:disable Gemspec/RequiredRubyVersion

s.files = Dir["{node_modules/govuk-frontend,node_modules/axe-core,node_modules/sortablejs,app,config,db,lib}/**/*", "LICENCE.md", "README.md"]

Expand Down

0 comments on commit 39bbb60

Please sign in to comment.