Skip to content

Commit

Permalink
Merge pull request #3635 from alphagov/ga4-contents-list
Browse files Browse the repository at this point in the history
Change GA4 contents list type
  • Loading branch information
andysellick authored Sep 25, 2023
2 parents f3eac48 + 8a4dbf2 commit d60259a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

## Unreleased

* Change GA4 contents list type ([PR #3635](https://github.com/alphagov/govuk_publishing_components/pull/3635))
* Change prev and next GA4 type ([PR #3631](https://github.com/alphagov/govuk_publishing_components/pull/3631))
* Remove timestamps from GA4 video urls ([PR #3632](https://github.com/alphagov/govuk_publishing_components/pull/3632))
* Add stylistic plugin for stylelint ([PR #3629](https://github.com/alphagov/govuk_publishing_components/pull/3629))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
ga4_tracking ||= false
ga4_data = {
event_name: "navigation",
type: "content",
type: "contents list",
section: t("components.contents_list.contents", locale: :en) || ""
} if ga4_tracking
local_assigns[:aria] ||= {}
Expand Down
2 changes: 1 addition & 1 deletion spec/components/contents_list_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def assert_tracking_link(name, value, total = 1)

expected_ga4_json = {
event_name: "navigation",
type: "content",
type: "contents list",
section: "Contents",
}

Expand Down

0 comments on commit d60259a

Please sign in to comment.