New options for contents-list component #4305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthillco
force-pushed
the
contents-list-landing-page-variant
branch
from
6e131a3 to
3b38fa3
Compare
matthillco
changed the title
matthillco
force-pushed
the
contents-list-landing-page-variant
branch
from
3b38fa3 to
ce338c8
Compare
jon-kirwan
reviewed
Oct 15, 2024
app/assets/stylesheets/govuk_publishing_components/components/_contents-list.scss
Outdated
Show resolved
Hide resolved
app/assets/stylesheets/govuk_publishing_components/components/_contents-list.scss
Outdated
Show resolved
Hide resolved
andysellick
reviewed
Oct 16, 2024
app/assets/stylesheets/govuk_publishing_components/components/_contents-list.scss
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/docs/contents_list.yml
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/docs/contents_list.yml
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/docs/contents_list.yml
Outdated
Show resolved
Hide resolved
app/assets/stylesheets/govuk_publishing_components/components/_contents-list.scss
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_contents_list.html.erb
Outdated
Show resolved
Hide resolved
matthillco
force-pushed
the
contents-list-landing-page-variant
branch
from
ce338c8 to
b51dd71
Compare
matthillco
force-pushed
the
contents-list-landing-page-variant
branch
from
a67fa01 to
0e4a79e
Compare
matthillco
force-pushed
the
contents-list-landing-page-variant
branch
from
0e4a79e to
c525784
Compare
andysellick
reviewed
Oct 16, 2024
app/assets/stylesheets/govuk_publishing_components/components/_contents-list.scss
Outdated
Show resolved
Hide resolved
app/assets/stylesheets/govuk_publishing_components/components/_contents-list.scss
Outdated
Show resolved
Hide resolved
matthillco
force-pushed
the
contents-list-landing-page-variant
branch
from
c525784 to
201be68
Compare
matthillco
force-pushed
the
contents-list-landing-page-variant
branch
from
201be68 to
0de1d6f
Compare
|
Hi @andysellick I've fixed all your requests, hopefully this can be merged now. |
andysellick
reviewed
Oct 17, 2024
app/views/govuk_publishing_components/components/_contents_list.html.erb
Show resolved
Hide resolved
app/assets/stylesheets/govuk_publishing_components/components/_contents-list.scss
Outdated
Show resolved
Hide resolved
matthillco
force-pushed
the
contents-list-landing-page-variant
branch
from
0de1d6f to
cd6ee5f
Compare
matthillco
force-pushed
the
contents-list-landing-page-variant
branch
from
cd6ee5f to
4819022
Compare
This was previously missing from this component and is added to meet our coding standards.
A new option for the contents-list component that can be used to apply a different line style: - No left hand indent - No dashes - Increased vertical space between lines - Different active style: bold blue text & blue vertical left border This option is only effective if the component instance uses active links.
matthillco
force-pushed
the
contents-list-landing-page-variant
branch
from
4819022 to
fc03300
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Two new options for the
contents-listcomponent:alternative_line_styletitleThese can be used to format the list as a navigation block on landing pages. Trello
Why
Landing pages have a navigation element in a sidebar. This navigation element can use the
contents-listcomponent. However, there are additional requirements which require new options:Visuals