Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github actions config and remove Jenkinsfile #46

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Add github actions config and remove Jenkinsfile #46

merged 1 commit into from
Jul 19, 2022

Conversation

BeckaL
Copy link
Contributor

@BeckaL BeckaL commented Jun 20, 2022 •
edited
Loading

As per RFC-123 we're moving away from Jenkins for testing and publishing our gems via github actions.

Trello

kevindew
kevindew approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@kevindew kevindew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a very minor thing to fix.

I've added the GitHub actions secret to this repo too so it can use the API key and removed the branch protection for Jenkins (this may get lost overnight so shout if you need it removing again)

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@BeckaL
Add github actions config and remove Jenkinsfile
4e358e9 
As per RFC-123 we're moving away from Jenkins for testing and publishing our gems
@BeckaL BeckaL force-pushed the switch-to-github-actions branch from 500b87e to 4e358e9 Compare July 19, 2022 07:59
@BeckaL BeckaL marked this pull request as ready for review July 19, 2022 15:40
@BeckaL BeckaL merged commit bbb9c37 into main Jul 19, 2022
@BeckaL BeckaL deleted the switch-to-github-actions branch July 19, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevindew kevindew kevindew approved these changes

@benjamineskola benjamineskola benjamineskola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BeckaL @benjamineskola @kevindew