Skip to content

Commit

Permalink
skip prometheus-client 0.10.0
Browse files Browse the repository at this point in the history
we saw exceptions on prod that I think might have caused a worker that
is being terminated to die ungracefully. While I'm not sure if this is
an actual problem that changed behaviour (app instances crashing and
restarting), at the very least it definitely polluted the logs and
obscured any actual issues we were having.

https://github.com/prometheus/client_python/releases/tag/v0.10.0

see the pending fix for this problem here:
prometheus/client_python#644
  • Loading branch information
leohemsted committed Apr 8, 2021
1 parent 5d2b18e commit 8954dc2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion requirements.in
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,6 @@ git+https://github.com/alphagov/notifications-utils.git@44.1.0#egg=notifications
git+https://github.com/alphagov/govuk-frontend-jinja.git@v0.5.8-alpha#egg=govuk-frontend-jinja==0.5.8-alpha

# gds-metrics requires prometheseus 0.2.0, override that requirement as later versions bring significant performance gains
prometheus-client==0.10.0
# version 0.10.0 introduced exceptions when workers crashed due to deprecating lower case `prometheus_multiproc_dir`.
prometheus-client>=0.9.0,!=0.10.0
gds-metrics==0.2.4
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ packaging==20.9
# via bleach
phonenumbers==8.12.20
# via notifications-utils
prometheus-client==0.10.0
prometheus-client==0.9.0
# via
# -r requirements.in
# gds-metrics
Expand Down

0 comments on commit 8954dc2

Please sign in to comment.