Pin patch version of govuk-elements-sass #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 3.1.3 changed heading classes to display block - alphagov/govuk_elements#552 This is a breaking change for us since we are using the heading classes to make font bold - 3.1.3 adds line breaks in places where we don't want them and causes some functional tests to fail. Since we will be replacing govuk-elements with the new design system, this commit pins the version of govuk-elements instead of updating all the code to work with the lastest version.
quis
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.1.3 of govuk-elements changed heading classes to display block (alphagov/govuk_elements#552). This is a breaking change for us since we are using the heading classes in a number of places that aren't headings in order to make font bold. Upgrading to 3.1.3 adds line breaks in places where we don't want them and causes some functional tests to fail.
I started by trying to update the CSS so that everything still looks the same with 3.1.3, but this was getting increasingly complicated. And since we will be replacing govuk-elements with the new design system soon anyway, it is simpler to pin the version of govuk-elements for now.
Example of an unwanted line break in version 3.1.3