-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from enzyme to react testing library #2754
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kr8n3r
force-pushed
the
move-from-enzyme-to-react-testing-library
branch
2 times, most recently
from
June 10, 2022 13:48
d5f56cb
to
2dfce9b
Compare
JSDOM HTML engine doesn't work quite like the browser as it will only render the value it is provided, so without our server we cannot test the input sanitisation.
kr8n3r
force-pushed
the
move-from-enzyme-to-react-testing-library
branch
from
June 10, 2022 13:54
2dfce9b
to
eb16231
Compare
schmie
approved these changes
Jun 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sampled equivalence of checks, some new TS complaints, but all suites passing - LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
We use React 18 but Enzyme react adaptor only supports 16. This wasn't an issue until this week our builds started failing to build (see below)
Enzyme seems to be dying a slow death, as there isn't even a react 17 adapter. Meanwhile RTL fully supports React 18 and we want to be able to upgrade in the future.
Migrating to @testing-library is the only logical option. Downgrading React isn't an option.
Addresses #2748
How to review
Who can review
not @kr8n3r
🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️ 🚨