185765111 tls support #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dark5un
force-pushed
the
185765111-tls-support
branch
from
f1761ba to
49ce0e9
Compare
dark5un
force-pushed
the
185765111-tls-support
branch
from
49ce0e9 to
a589c10
Compare
dark5un
force-pushed
the
185765111-tls-support
branch
from
95cf230 to
aeb56f0
Compare
|
I have seen that the integration tests worked. I have implemented the tls rds broker in dev05 and used the broker to create services, bind apps, unbind apps and delete services. It all looks good to me. |
* Includes integration test covering selfsigned TLS
dark5un
force-pushed
the
185765111-tls-support
branch
from
e6f5f4d to
095d8ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of RDS broker does not use github.com/alphagov/paas-service-broker-base. For the time being I have "borrowed" and converted parts of it to make
RDS-Brokersupport TLS connectivity.How to test: