Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessibility issues by updating the govuk_tech_docs gem to 2.2.0 #399

Merged
merged 2 commits into from
Mar 14, 2021

Conversation

kr8n3r
Copy link
Contributor

@kr8n3r kr8n3r commented Mar 14, 2021

What

First, update the govuk_tech_docs gem from 2.1.0 to 2.2.0.

Change log

2.2.0

Accessibility Fixes

Docs

2.1.1

Fixes

We’ve made fixes in the following pull requests:

Ruby version bump

We've updated the Ruby version supported:

This PR

  • updates the dependencies
  • adds row headers to tables

Example of table row header change

Before

Screenshot 2021-03-14 at 16 32 58

After

Screenshot 2021-03-14 at 16 33 38

Why

Version 2.2.0 of the tech docs gem is now live and incorporates fixes to a number of accessibility issues in the technical documentation template which are referenced in our accessibility statement:

  • Some tables in content do not have column row headers when needed.
  • Users cannot tab to code examples to scroll them using the keyboard.
  • The search field and the ‘Hide table of contents’ button are not placed logically in the focus order.
  • Users can focus elements that are hidden visually behind other content, for example when using the search field.
  • Images link to a new tab without telling users, and do not have link text.

How to review

  • check for any tables that have missing row header
  • cookie banner buttons stil look good

Who can review

not @kr8n3r

@kr8n3r kr8n3r merged commit 8a3de3d into main Mar 14, 2021
@kr8n3r kr8n3r deleted the update-tech-docs-gem branch March 14, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant