PP-1606 Add spacer <span>s for admin-list items

Only effects admin-lists marked up as tables.
alphagov · Apr 12, 2017 · d7fa6c8 · d7fa6c8
1 parent 733e5b6
commit d7fa6c8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/app/assets/sass/helpers/_admin_list.scss b/app/assets/sass/helpers/_admin_list.scss
@@ -27,17 +27,22 @@
 
   /* Row content styles */
   .admin-list-heading,
-  a {
+  a,
+  span {
     padding: 0.75em 1.25em 0.5625em 0;
   }
 
   /* Styles specific to certain tags */
   ul {
     list-style: none;
 
+    a,
+    span {
+      display: block;
+    }
+
     a {
       text-decoration: none;
-      display: block;
       cursor: pointer;
 
       &,

diff --git a/app/views/services/team_members.html b/app/views/services/team_members.html
@@ -23,8 +23,10 @@ <h3 id="admin-role-header" class="admin-list-heading">Administrators ({{number_a
                 {{#team_members.admin}}
                 <li>
                     {{#permissions.users_service_read}}<a id="user-external-id-{{external_id}}" href="{{link}}">{{/permissions.users_service_read}}
+                    {{^permissions.users_service_read}}<span>{{/permissions.users_service_read}}
                     {{username}} {{#is_current}}(you){{/is_current}}
                     {{#permissions.users_service_read}}</a>{{/permissions.users_service_read}}
+                    {{^permissions.users_service_read}}</span>{{/permissions.users_service_read}}
                 </li>
                 {{/team_members.admin}}
             </ul>
@@ -36,8 +38,10 @@ <h3 id="view-and-refund-role-header" class="admin-list-heading">View and refund
                 {{#team_members.view-and-refund}}
                 <li>
                     {{#permissions.users_service_read}}<a id="user-external-id-{{external_id}}" href="{{link}}">{{/permissions.users_service_read}}
+                    {{^permissions.users_service_read}}<span>{{/permissions.users_service_read}}
                     {{username}} {{#is_current}}(you){{/is_current}}
                     {{#permissions.users_service_read}}</a>{{/permissions.users_service_read}}
+                    {{^permissions.users_service_read}}</span>{{/permissions.users_service_read}}
                 </li>
                 {{/team_members.view-and-refund}}
             </ul>
@@ -49,8 +53,10 @@ <h3 id="view-only-role-header" class="admin-list-heading">View only ({{number_vi
                 {{#team_members.view-only}}
                 <li>
                     {{#permissions.users_service_read}}<a id="user-external-id-{{external_id}}" href="{{link}}">{{/permissions.users_service_read}}
+                    {{^permissions.users_service_read}}<span>{{/permissions.users_service_read}}
                     {{username}} {{#is_current}}(you){{/is_current}}
                     {{#permissions.users_service_read}}</a>{{/permissions.users_service_read}}
+                    {{^permissions.users_service_read}}</span>{{/permissions.users_service_read}}
                 </li>
                 {{/team_members.view-only}}
             </ul>