Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish /privacy-notice page #2321

Merged
merged 5 commits into from
Aug 24, 2023
Merged

Conversation

mike29736
Copy link
Contributor

@mike29736 mike29736 commented Aug 23, 2023

https://trello.com/c/AgYOfi7y/239-publish-the-signon-privacy-notice-and-link-to-it-in-signon-page

To meet one of the requirements of our Data Protection Impact Assessment, we're publishing this privacy notice and cookie policy for users of Signon.

I've had one eye on the styling of https://www.gov.uk/help/privacy-notice while working on this. Though, since that's a public facing page, I don't really know how similar this needs to be 😕

There's a suggestion on the Trello card about explaining what the page is for when linking to it. I haven't found an appropriate place to do that, since I've followed the convention of just including the link in the site's footer.

Things I'm still wondering:

  • should the page heading have fewer capital letters in it?
  • should the URL and footer link text include "cookie policy" in them?

@chrisroos chrisroos self-assigned this Aug 23, 2023
Copy link
Contributor

@chrisroos chrisroos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mike29736.

Should the Privacy notice be publicly accessible? It feels slightly odd to me that it's linked to from the footer of the sign in page but that users have to sign in to be able to view it.

I'm not seeing the different page_heading and title when I view this page locally. I see "Privacy notice and cookie policy" in the browser tab title and on the page itself, which doesn't seem to be what you'd intended.

image

Do we need to include information about other cookies (e.g. the dismiss_user_research_recruitment_banner)?

@mike29736
Copy link
Contributor Author

mike29736 commented Aug 23, 2023

Hi @mike29736.

Should the Privacy notice be publicly accessible? It feels slightly odd to me that it's linked to from the footer of the sign in page but that users have to sign in to be able to view it.

I'm not seeing the different page_heading and title when I view this page locally. I see "Privacy notice and cookie policy" in the browser tab title and on the page itself, which doesn't seem to be what you'd intended.

image

Do we need to include information about other cookies (e.g. the dismiss_user_research_recruitment_banner)?

Thanks @chrisroos,

  1. You're right, I'll make it public -- done ✔️

  2. My only idea about the page_heading/title issue is something something asset compilation. But the layout isn't an asset, so for now I'm stumped.

  3. I'll add the banner cookie to the table some information about the banner cookie and run it past Nick. I completely forgot to write this down when it came up yesterday 😬 -- done ✔️ see: 3948b0b#diff-bf1d2e96e0c7cb5740e2be00cfcd3c2efb1d6c4458e2a0b924f9af383c771b25R42

@mike29736 mike29736 force-pushed the publish-the-signon-privacy-notice branch from 4c30f34 to 0a95b67 Compare August 23, 2023 13:47
Using `rails generate govuk_publishing_components:component
[component_name]` (see
https://github.com/alphagov/govuk_publishing_components/blob/main/docs/generate-a-new-component.md).

I want to use the same style for contact details (e.g. postal address)
as on public facing GOV.UK pages (e.g.
https://www.gov.uk/help/privacy-notice).

I can't find anything suitable in the components provided by the gem, so
I've created this component that remains local to the Signon app.
An upcoming commit introduces a page with quite a long page heading
which happens to include the name of the app in it. The resulting page title, with its
automatically suffixed app name, doesn't make for great reading!

This change allows us control over both independently, if and when we
want to use it.
To meet one of the requirements of our Data Protection Impact
Assessment, we're publishing this privacy notice and cookie policy for
users of Signon.

I've specified a distinct page title and page heading to avoid the
duplication of the app's name in the <title>.

I've used as many GOV.UK publishing components in the building of this
page as made sense to me.

To be honest, I have very little understanding of the differences
between public and admin styles and no understanding of the thinking
behind those differences. For those reasons, I'm not 100% confident how
this page should look.

The page uses the publishing components Admin Layout (as opposed to the
Public Layout), because all of Signon uses it and this page isn't public
facing even though it takes some cues from public facing pages (e.g.
https://www.gov.uk/help/privacy-notice).

Because the Admin Layout doesn't appear to style links the way that we
expect them to look on GOV.UK pages (with content similar to this one)
and because it doesn't appear to enforce the use of the GDS Transport
font family, I've used `govuk-body` and `govuk-link` CSS classes to
achieve the same effect.

For the published date line at the end of the page, I've styled the text
to match how that information looks on public facing GOV.UK pages. There
is a Published Date component that lives in the Government Frontend
codebase (not shared through the components gem), but the effort to move
that into the gem only to not end up using any of its features (for now)
didn't seem worth it.
@mike29736 mike29736 force-pushed the publish-the-signon-privacy-notice branch from 0a95b67 to 77c48d9 Compare August 23, 2023 16:36
Copy link
Contributor

@chrisroos chrisroos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mike29736 :-) This all looks good to me 👍

@mike29736 mike29736 merged commit 9f0f858 into main Aug 24, 2023
@mike29736 mike29736 deleted the publish-the-signon-privacy-notice branch August 24, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants