Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide permissions for API-only apps on users index page #2457

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Hide permissions for API-only apps on users index page #2457

merged 2 commits into from
Oct 26, 2023

Conversation

floehopper
Copy link
Contributor

@floehopper floehopper commented Oct 24, 2023 •
edited
Loading

Trello: https://trello.com/c/kvmb5OHO

Previously, despite #2452, we were still showing permissions for API-only apps in the permissions filter on the users index page. Joseph spotted that I had missed it. This PR should fix it!

Before

Screenshot 2023-10-24 at 18 07 43

After

Screenshot 2023-10-24 at 18 07 56

@floehopper floehopper requested a review from chrislo October 24, 2023 17:19
chrislo
chrislo approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@chrislo chrislo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@floehopper
Add test for retired app permissions on users page
3d04057 
The behaviour being tested was actually introduced when we added the
`not_retired` scope to the default scope for `Doorkeeper::Application`
in this commit [1] in #2446. However, I'm about to make some changes in
this area and I want to have some coverage in place beforehand.

[1]: 9a9cd02
@floehopper
Hide API-only app permissions on users page
f76d0ca 
Joseph spotted that I missed this in #2452. Now fixed!
@floehopper floehopper force-pushed the hide-permissions-for-api-only-apps-on-users-index-page branch from 6f5064d to f76d0ca Compare October 26, 2023 12:50
@floehopper floehopper merged commit c6a0fb3 into main Oct 26, 2023
10 checks passed
@floehopper floehopper deleted the hide-permissions-for-api-only-apps-on-users-index-page branch October 26, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislo chrislo chrislo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floehopper @chrislo