Restructure users controller test #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is over 800 lines long and I was struggling to find my way around it. I think that using top-level contexts for the actions is a bit less surprising. The diff is best viewed using the `--ignore-all-space` git diff option, because lots of the indentation has changed.
This test is over 800 lines long and I was struggling to find my way around it. I think that consistently using 2nd-level contexts for signing in different current user roles is less suprising. The diff is best viewed using the `--ignore-all-space` git diff option, because lots of the indentation has changed.
chrislo
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UsersControllerTestis over 800 lines long and I was struggling to find my way around it. I think that using top-level contexts for the actions and 2nd-level contexts for signing in users with different roles is a bit less surprising.My motivation for making these changes is that I'm currently working on the user edit page which means I'll be making a lot of changes in this area. Making these changes first will make that easier. And getting the commits merged soon will reduce the chance of any merge conflicts.
The commits are best viewed with the
--ignore-all-spacegit diff option, because lots of the indentation has changed.