Reduce applications table action links layout #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yndajas
force-pushed
the
reduce-applications-table-action-links-layout
branch
3 times, most recently
from
5fce1c2 to
f859455
Compare
Our table helper and table template are modified versions taken from GOV.UK Publishing Components. This extends them further
At present, on viewports of between 940px and 1199px, the actions links/buttons are various shades of messy, owing to the fact that they share a single column, use `flex` alignment, and are of different widths This updates the layout so that the actions links/buttons are nicely aligned and consistently positioned at all viewport sizes and regardless of which of the four links/buttons appear in the given tables - The visible text is simplified, favouring a combination of a visible column heading of "Access" or "Permissions" combined with single-word actions. The text read by a screen reader in each column should remain the same: the part no longer visible in individual links/buttons is simply moved to the visually-hidden `span` - The access column is moved before the permissions column to make the column order more in sync between the two tables - The `description` column width is increased, retaining a good whitespace distribution across the table and potentially reducing the line count for apps with longer descriptions
This makes it a bit clearer what the various passed in strings are for
yndajas
force-pushed
the
reduce-applications-table-action-links-layout
branch
from
05895dd to
de5061b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
At present, on viewports of between 940px and 1199px, the actions links/buttons are various shades of messy, owing to the fact that they share a single column, use
flexalignment, and are of different widthsThis updates the layout so that the actions links/buttons are nicely aligned and consistently positioned at all viewport sizes and regardless of which of the four links/buttons appear in the given tables
Screenshots
Before
940px
1199px
After
940px
1199px
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.