Rails 8 upgrade #3546
Open
Rails 8 upgrade #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unoduetre
force-pushed
the
rails-8-upgrade
branch
2 times, most recently
from
d04a395 to
5a08498
Compare
unoduetre
commented
Dec 31, 2024
| @@ -11,24 +11,20 @@ | |||
| # While tests run files are not watched, reloading is not necessary. | |||
| config.enable_reloading = false | |||
|
|
|||
| # Turn false under Spring and add config.action_view.cache_template_loading = true. | |||
There was a problem hiding this comment.
It's redundant as it's the opposite of config.enable_reloading defined above.
|
Please, see the comments in alphagov/frontend#4556 |
unoduetre
force-pushed
the
rails-8-upgrade
branch
from
5a08498 to
fb30637
Compare
unoduetre
commented
Dec 31, 2024
| @@ -43,20 +41,17 @@ | |||
| config.active_support.disallowed_deprecation_warnings = [] | |||
|
|
|||
| # Raises error for missing translations. | |||
| # config.i18n.raise_on_missing_translations = true | |||
| config.i18n.raise_on_missing_translations = true | |||
There was a problem hiding this comment.
For consistency with other apps. This is for the development environment only.
unoduetre
commented
Dec 31, 2024
| config.action_controller.raise_on_missing_callback_actions = true | ||
|
|
||
| # Apply autocorrection by RuboCop to files generated by `bin/rails generate`. | ||
| # config.generators.apply_rubocop_autocorrect_after_generate! | ||
| config.generators.apply_rubocop_autocorrect_after_generate! |
There was a problem hiding this comment.
For consistency with other apps. This is for the development environment only.
unoduetre
force-pushed
the
rails-8-upgrade
branch
from
fb30637 to
383e784
Compare
unoduetre
commented
Dec 31, 2024
| @@ -46,7 +46,6 @@ | |||
| global_bar: global_bar, | |||
| homepage: homepage_blue_navbar, | |||
| logo_link: logo_link, | |||
| product_name: product_name, | |||
There was a problem hiding this comment.
This line is duplicated below, so I'm removing it. It caused a warning from Ruby.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow these steps if you are doing a Rails upgrade.
What
Update our apps to run Rails 8
Why
To keep our apps up to date and using the latest software to include bug fixes and security updates.
Trello ticket