Remove selector-pseudo-element-colon-notation
#36
Conversation
|
Think we're happy with this now @querkmachine if you'd like to bring it out of draft Will probably want it to land before #32 🙌 |
|
Great, one thing I wonder is are we flipping this rule to be the stylelint default? if so we can just remove the rule rather than edit it |
|
@kevindew I think it's now the same as the default, yeah. I figured switching it explicitly rather than removing might make it more obvious that changing it was a conscious decision (we want folks to update their authored code, not override it again in their local configs) but I can't rightfully say whether anyone would actually notice! |
Yup, that makes sense. Though our project goals are to have only things that differ from community standards so would be more consistent to remove it. |
The Design System team is in the process of removing support for Internet Explorer 8, 9 and 10 from GOV.UK Frontend, signalling our intent to no longer support the browser or provide fixes or polyfills specifically for it. Supporting IE8–10 has not been a requirement for services since June 2018. Barring legacy projects, we do not expect services to be making accommodations for legacy IE versions now or in future, and encourage those projects to begin removing any code specifically for these versions of IE. As part of this, we should remove `selector-pseudo-element-colon-notation` to begin enforcing the default standards-compliant double-colon syntax instead.
querkmachine
force-pushed
the
kg-update-pseudo-elements
branch
from
fa2673e to
5b3456c
Compare
querkmachine
changed the title
selector-pseudo-element-colon-notationselector-pseudo-element-colon-notation
|
@kevindew Fair enough! I've updated the PR to remove it instead. |
The Design System team is in the process of removing support for Internet Explorer 8, 9 and 10 from GOV.UK Frontend, signalling our intent to no longer support these browsers or provide fixes or polyfills specifically for them.
Supporting IE8–10 has not been a requirement for services since June 2018.
We do not expect service teams to continue making accommodations for legacy IE versions now or in future and are encouraging them to begin removing any code specifically for these versions of IE.
As part of this, we should remove
selector-pseudo-element-colon-notationto begin enforcing the default standards-compliant double-colon syntax instead.